Advanced Custom Fields

Local JSON: scan_files() reads and decodes every JSON file up to 4 times on every request
On every request, ACF_Local_JSON has four callbacks registered on the acf/include_* actions: * include_fields * include_post_types * include_taxonomies * ACF_UI_Options_Page::include_json_options_pages Each callback calls scan_files( $post_type ). scan_files() walks every load path, then file_get_contents() and json_decode() every .json file, just to read its key and decide whether the file belongs to the type being scanned. After that, each matching file is decoded a second time when it gets registered. So every JSON file is read and decoded four times per request, plus once more for the type it belongs to. This happens even when a type has no JSON at all: we have no post types, taxonomies or options pages in JSON, and those three scans still decode all 145 field-group files. Measured impact (production site, 13 load paths, 145 JSON files, about 1.2 MB): Callback Time include_fields ~34 ms include_post_types ~17 ms include_taxonomies ~17 ms include_json_options_pages ~17 ms Total ~85 ms That's about 85 ms on every request that misses the page cache: logged-in pages, cart, checkout, admin-ajax, and REST. Suggested fixes Scan once per request. Decode each file a single time, group the results by type (the key prefix), and let the four include_* callbacks read from that one result. Cache the scan across requests, with a cache key built from each file's path, mtime, and size, so an edit or a sync invalidates it straight away.
1
·
planned
Automatically initialize WYSIWYG fields using IntersectionObserver
Admin pages with a lot of WYSIWYG fields can be significantly slow to load. That's why there is the option "Delay Initialization", that waits for the editor to be initialized as soon as the user clicks it. The related JS is from the days before IntersectionObserver was born – but it could now definitely be improved so that TinyMCE will be initialized as soon as the field enters the viewport. Here's a little function I wrote that does exactly that: /** * Attaches an intersection observer to delayed WYSIWYG fields * to enable them automatically if scrolled into view * * Uses the `ready_field` and field.addAction('load') actions * @see https://www.advancedcustomfields.com/resources/javascript-api/#actions-ready_field * @see https://www.advancedcustomfields.com/resources/javascript-api/#actions-load_field */ handleACFWysiwygField = () => { /** * Is the field delayed? */ const isDelayed = (field) => { return field.$control().hasClass("delay"); }; /** * This function will be injected into the ACF field object. * So `this` will be the field */ function observe() { if (!isDelayed(this)) { return; } const field = this; const $wrap = field.$control(); const observer = new IntersectionObserver( (entries) => { if (entries[0].isIntersecting) { $wrap.trigger("mousedown"); observer.disconnect(); } }, { rootMargin: "300px 0px", } ); observer.observe($wrap[0]); } /** * As soon as the field is ready, prepare it * for observation */ function onReady(field) { if (!isDelayed(field)) { return; } field .$control() .find(".acf-editor-toolbar") .text("Initializing Editor ..."); field.observe = observe.bind(field); field.addAction("load", field.observe); } acf?.addAction("ready_field/type=wysiwyg", onReady); }; The function does the following things: wait for any wysiwyg field to be ready if the field is delayed wait for the field to be fully loaded ( field.addAction('load') ) patches the field with an "observe" function, that observes it and initializes the editor as soon as the field becomes within 400px of the viewport As this all can already be done using the JS API, I thought it would be worth sharing it publicly. But if the ACF support is reading this, maybe they'd consider adding the functionality to the core?
0
Load More
→